-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to validate the EC2Cloud private key migration #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this PR superseeds #498 right?
public JenkinsRule r = new JenkinsRule(); | ||
|
||
@Test | ||
@LocalData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some comment explaining that the local data is from a previous version of EC2 to show it clear the migration works? Or maybe in the config.xml you can add a comment noticing the privateKey
is the actual key and not a credential and it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
I don't pretend this to supersede the original PR, only to demonstrate how to use LocalData to perform the related testing. |
This breaks the plugin. We ended up rolling back. |
@CptPlastic this only adds a test, so I guess you'll be referring to a previous PR. Which version did you update to? |
this is raised as https://issues.jenkins-ci.org/browse/JENKINS-63707 |
Adds to #498 an automated test validating the migration for an EC2 cloud is correctly done.
@MRamonLeon @djesionek